pass relative paths to the command line #4437
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation to do this is avoid noise and easier to for ppx commands to selectively filter some files To achieve this, we need ensure that error message is displayed properly so that refmt is tweaked to set absname true The other benefit is that this makes our path resolution much more white space in-sensitive TODO: make sure editor integration is okay. The merlin should be fine, since it does not rely on the compiler commands If RLS does run those command faithfully it should be fine too
|
in maser, for the source file, it is still absolute path, for output, it's relative, this makes existing editor happy but also reduce the verbosity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation to do this is avoid noise and easier to for ppx commands to selectively filter some files
To achieve this, we need ensure that error message is displayed properly so that refmt is tweaked to set absname true
The other benefit is that this makes our path resolution much more white space in-sensitive
TODO: make sure editor integration is okay.
The merlin should be fine, since it does not rely on the compiler commands
If RLS does run those command faithfully it should be fine too